Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor backend & verification sytem. #76

Merged
merged 10 commits into from
Feb 10, 2023
Merged

Refactor backend & verification sytem. #76

merged 10 commits into from
Feb 10, 2023

Conversation

cohenerickson
Copy link
Member

@cohenerickson cohenerickson commented Feb 6, 2023 •
edited by GreenyDEV
Loading

What does this PR do?

  • convert backend to express
  • secure OTP mode with bcrypt
  • restructure files
  • convert to the usage of @titaniumnetwork-dev/ultraviolet instead of statically hosting files

Major changes

  • OTP verification now has proper sessions and is encrypted with bcrypt

@cohenerickson cohenerickson added the enhancement New feature or request label Feb 6, 2023
@cohenerickson cohenerickson marked this pull request as ready for review February 9, 2023 21:22
GreenyDEV
GreenyDEV requested changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@GreenyDEV GreenyDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the filestructure section in README? Other than that, looks good!

cohenerickson
cohenerickson commented Feb 10, 2023
View reviewed changes
Copy link
Member Author

@cohenerickson cohenerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@cohenerickson cohenerickson merged commit 9de8d5f into NebulaServices:main Feb 10, 2023
@cohenerickson cohenerickson mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3kh0 3kh0 3kh0 approved these changes

@GreenyDEV GreenyDEV Awaiting requested review from GreenyDEV

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cohenerickson @3kh0 @GreenyDEV