Custom CSS, AB Customization, ~~UV linking/config fix~~ #79
Conversation
Not sure if the AB Cloak is working 100%, so if someone could test it out would appreciate. (Probably won't break AB if not?)
This reverts commit b807362.
Not sure if the AB Cloak is working 100%, so if someone could test it out would appreciate. (Probably won't break AB if not?)
|
LGTM! Ideally we get documentation alongside this soon, right? |
Yep, The setup for custom themes is pretty specific and interactive, not just paste block of code. But I'll write some docs likely to show where the colors/elements go if names aren't clear enough |
|
yo @cohenerickson I think refactoring is done? I don't think this'll have issues, just could u take a look? |
|
It seems like the link isn't correctly being generated. When navigating to |
|
I am referring to the cloak system |
I think this was an issue before and not with my code, I'll take a look to see |
What's your system |
|
All known bugs need to be fixes before changes are merged, please take a look at what Cohen mentioned. |
Alright, will see what's going on here, seems to be unrelated my code, but I will take a crack at it |
|
Also make sure the code you edited is the latest code! |
Yes, will do this time lmfao, Should be fine pulling from my branch |
|
Ok I think I've identified a fix, but I do not wish to break things, and also it doesn't make much sense.
Ignore all this please look below at my messages/commit |
|
After some slow cross-referencing, https://github.com/titaniumnetwork-dev/Ultraviolet/blob/main/src/uv.sw.js#L34 can be seen with |
|
issue is it's setting the wrong prefix @cohenerickson could you take care of this? this shouldn't be anything I've done as I didn't even touch how A:B loads |
The only thing that confuses me rn is why explicitly @cohenerickson said to make it |
|
I'm going to just revert my changes for now until Cohen looks at this thread This is a Nebula issue outside of my fork/PR (See #84 ) |
|
we're working on a fix for the service bug |
Cattn
changed the title
|
This is not true, the official documentation for the ultraviolet library explicitly states that it can be done, I can fix this later today but not for a few more hours. It is simply just an issue with the order express is handling static routes. The reason this wasn't caught by me in the beginning was due to the inconsistencies in the codebase by either explicitly stating the prefix as a string or using the |
|
Please resolve conflicts with 059526d |
Will do |
|
Fixed, merging now! |
Cattn
changed the title
Not sure if the AB Cloak is working 100%, so if someone could test it out would appreciate. (Probably won't break AB if not?)
I suggest whoever checks this will test the AB Feature beforehand. It should have no issue, but for the sake of it would probably be good to test.
(Sorry for 3 commits lol had some issues)