Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parsing and error handling for better responses #47

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

NeonDaniel
Copy link
Member

Description

Remove EnglishQuestionParser class and references
Refactor error handling for HANA backend

Issues

Other Notes

Prompted by observing parsing that broke a request and resulted in no response being spoken:

2024-06-17 16:33:25.525 - skills - skill_fallback_wolfram_alpha:CQS_match_query_phrase:135 - INFO - what is distance to mars
2024-06-17 16:33:25.605 - skills - skill_fallback_wolfram_alpha:_query_wolfram:187 - DEBUG - {'QuestionWord': 'what', 'QuestionVerb': 'to', 'Query': 'is distance mars'}
2024-06-17 16:33:25.620 - skills - skill_fallback_wolfram_alpha:_query_wolfram:195 - DEBUG - 3
2024-06-17 16:33:25.629 - skills - skill_fallback_wolfram_alpha:_query_wolfram:197 - DEBUG - Querying WolframAlpha: what to is distance mars

Refactor error handling for HANA backend
@NeonDaniel NeonDaniel merged commit 3126832 into dev Jun 18, 2024
5 checks passed
@NeonDaniel NeonDaniel deleted the REF_RemoveExtraParsing branch June 18, 2024 00:20
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant