Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Improved substring matching #26

Open
NeonDaniel opened this issue Apr 19, 2023 · 1 comment
Open

[FEAT] Improved substring matching #26

NeonDaniel opened this issue Apr 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@NeonDaniel
Copy link
Member

NeonDaniel commented Apr 19, 2023

Objective

Currently, a title is matched in the search phrase, so a title "He" will match "The" in an utterance. This should be updated to only search words, not substrings.

Initial Implementation Requirements

  • Update search logic to search on boundaries
  • Implement unit tests

Other Considerations

  • Does this realistically only apply to one-word titles?
  • Can/should we boost or lower confidence based on percent of substring matched?
@NeonDaniel
Copy link
Member Author

Relating to confidence based on substrings matched, confidence could be reduced with track/album/artist length since a longer string must have matched more of the utterance

from chat: https://matrix.to/#/!XeBSsfCqDoWgGMihCz:matrix.org/$6TcYExvFFAe4ZoTysqWwZZ8ABD5nRReJjXU6Cx1AR6I?via=matrix.org

@NeonDaniel NeonDaniel removed their assignment May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Other Helpful Tasks
Development

No branches or pull requests

1 participant