Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attachment truncation to avoid missing attachments #80

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jul 3, 2024

Description

Update logic and tests to take last 1MB of log files instead of approximating by lines

Issues

Closes #81

Other Notes

The email proxy will attempt to send an email with all passed attachments. If this exceeds the maximum allowed by the email provider and the send fails, then all attachments are discarded.

@NeonDaniel NeonDaniel marked this pull request as ready for review July 5, 2024 16:50
@NeonDaniel NeonDaniel merged commit 9e07c4b into dev Jul 5, 2024
18 checks passed
@NeonDaniel NeonDaniel deleted the FIX_TruncateLogsByFileSize branch July 5, 2024 18:18
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Attachments missing from support email
1 participant