Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FileSaver.js #262

Closed
nomego opened this issue Mar 7, 2019 · 3 comments
Closed

Upgrade FileSaver.js #262

nomego opened this issue Mar 7, 2019 · 3 comments

Comments

@nomego
Copy link
Contributor

nomego commented Mar 7, 2019

In the git history we stayed with FileSaver 1.3.4 cause 1.3.6 was broken (9fee62c).

According to https://github.com/eligrey/FileSaver.js/releases, 1.3.6 "fixed" (eligrey/FileSaver.js#408) where 1.3.8 reverted it.

Was that the issue that broke everything and is it now safe to go back to the latest version 2.0.0?

@nomego
Copy link
Contributor Author

nomego commented Mar 8, 2019

The issue was actually eligrey/FileSaver.js#409 but it should be resolved with v2.0.0, which we would upgrade to if we dropped the specific dep and let the filesaver import component handle the dependency.

nomego pushed a commit that referenced this issue Mar 8, 2019
Fixes #262

Signed-off-by: Patrik Kullman <patrik.kullman@neovici.se>
@erayd
Copy link

erayd commented May 30, 2019

@nomego I'm not convinced that #408 is fixed. Some filetypes work, and some (e.g. markdown) fail abysmally and simply cause Chrome to spawn a new tab at about:blank#blocked instead.

@nomego
Copy link
Contributor Author

nomego commented Jun 24, 2019

Fixed by Polymer 3 upgrade.

@nomego nomego closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants