Use StepCounter instead of BasicCounter #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepCounter has more overhead, but the normalization and sampling of BasicCounter can lead to rate variations when aggregating across many counters. Example of from counters that should all be the same: atlas_2014_22_10_15_42_01_951.log.gz 1.618458 ReciprocalRank 1.545702 Rank 1.672844 RankFraction 1.763815 BinaryDiscountedCumulativeGain atlas_2014_22_10_15_42_57_012.log.gz 1.284395 ReciprocalRank 1.248162 Rank 1.248178 RankFraction 1.356733 BinaryDiscountedCumulativeGain atlas_2014_22_10_15_43_52_066.log.gz 2.111525 ReciprocalRank 1.856574 Rank 1.983977 RankFraction 2.220634 BinaryDiscountedCumulativeGain atlas_2014_22_10_15_44_47_197.log.gz 1.832837 ReciprocalRank 1.742114 Rank 1.760254 RankFraction 1.941755 BinaryDiscountedCumulativeGain atlas_2014_22_10_15_45_42_452.log.gz 2.210017 ReciprocalRank 2.064924 Rank 2.264092 RankFraction 2.336758 BinaryDiscountedCumulativeGain
brharrington
added a commit
that referenced
this pull request
Oct 22, 2014
Use StepCounter instead of BasicCounter
|
Example of difference, first part is with BasicCounter second part is with StepCounter:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StepCounter has more overhead, but the
normalization and sampling of BasicCounter
can lead to rate variations when aggregating
across many counters. Example of from
counters that should all be the same:
atlas_2014_22_10_15_42_01_951.log.gz
1.618458 ReciprocalRank
1.545702 Rank
1.672844 RankFraction
1.763815 BinaryDiscountedCumulativeGain
atlas_2014_22_10_15_42_57_012.log.gz
1.284395 ReciprocalRank
1.248162 Rank
1.248178 RankFraction
1.356733 BinaryDiscountedCumulativeGain
atlas_2014_22_10_15_43_52_066.log.gz
2.111525 ReciprocalRank
1.856574 Rank
1.983977 RankFraction
2.220634 BinaryDiscountedCumulativeGain
atlas_2014_22_10_15_44_47_197.log.gz
1.832837 ReciprocalRank
1.742114 Rank
1.760254 RankFraction
1.941755 BinaryDiscountedCumulativeGain
atlas_2014_22_10_15_45_42_452.log.gz
2.210017 ReciprocalRank
2.064924 Rank
2.264092 RankFraction
2.336758 BinaryDiscountedCumulativeGain