Simplify framesync API #1327
Open
Simplify framesync API #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stacked on top of #1325 |
|
I feel like it might be more intuitive to pass the data pointer back and forth rather than just index. Thoughts on that idea? |
|
Sorry, could you clarify what you mean by
is that the current status at #1325 or is there any difference in what you suggest? |
|
@kylophone hi, can we go ahead with this one? |
I think we still need to wait on the pr using this. I was expecting something sooner, so I'll ping them and see what's up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dataparameter tovmaf_framesync_submit_filled_dataandvmaf_framesync_release_bufwas only used to check that it was the same pointer that was present in the framesync internal data structure. I believe this can be simplified.As an example usage, the
integer_funqueimplementation here creates two dummy variables,shared_buf_tempanddependent_buf_temp, just to pass into these functions. With this simplification, we could avoid those.