Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARG placement in Dockerfile.cuda #1383

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

guyoun
Copy link
Contributor

@guyoun guyoun commented Aug 7, 2024

An ARG declared before a FROM is outside of a build stage, so it can't be used in any instruction after a FROM

From https://docs.docker.com/reference/dockerfile/#understand-how-arg-and-from-interact

@nilfm99
Copy link
Collaborator

nilfm99 commented Aug 7, 2024

This looks correct, thank you. Sorry about the build failures, I am looking into them separately. We will also fix the typo FFFMPEG -> FFMPEG, feel free to make that change yourself or I will make a follow up PR for it.

@nilfm99 nilfm99 self-requested a review August 7, 2024 14:37
```
An ARG declared before a FROM is outside of a build stage, so it can't be used in any instruction after a FROM
```
From https://docs.docker.com/reference/dockerfile/#understand-how-arg-and-from-interact
@nilfm99 nilfm99 merged commit 8c38ef3 into Netflix:master Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants