Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit in ClientVersionV1 to have only 4 bytes of info following the spec #7013

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix commit in ClientVersionV1 to have only 4 bytes of info following the spec #7013

merged 2 commits into from
May 14, 2024

Conversation

smartprogrammer93
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 commented May 13, 2024 •
edited
Loading

Following spec here: https://github.com/ethereum/execution-apis/blob/main/src/engine/identification.md

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@smartprogrammer93 smartprogrammer93 merged commit bfd7c95 into master May 14, 2024
67 checks passed
MarekM25
MarekM25 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add version and commit to client info

@smartprogrammer93 smartprogrammer93 deleted the fix/clientversion-commit-only-4-bytes branch May 14, 2024 07:40
@smartprogrammer93 smartprogrammer93 mentioned this pull request Jun 6, 2024
Merged
14 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smartprogrammer93 @MarekM25