Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC/block tests upgraded to sepolia, fixed not running correct RPC url passed from env flag on CLI bug #566

Merged

Conversation

thiagodeev
Copy link
Collaborator

  • Upgraded block_test.go tests to Sepolia network.
  • Implemented TestBlockWithTxsAndInvokeTXNV1 test.
  • Fixed the bug that ignored the correct RPC URL passed by the 'env' flag in the CLI during testing (e.g. "go test -v . -env devnet" did not load the Devnet RPC), instead getting the Sepolia URL.

Partially resolves the issue #551.

@rianhughes rianhughes self-requested a review May 13, 2024 12:59
rpc/block_test.go Outdated Show resolved Hide resolved
rpc/block_test.go Outdated Show resolved Hide resolved
rpc/block_test.go Outdated Show resolved Hide resolved
rpc/block_test.go Outdated Show resolved Hide resolved
@rianhughes rianhughes merged commit dca89da into NethermindEth:main May 14, 2024
2 checks passed
@thiagodeev thiagodeev deleted the thiagodeev/fix-rpc-block-tests branch May 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants