Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct json tag price_in_fri #572

Merged
merged 1 commit into from
Jun 12, 2024
Merged

correct json tag price_in_fri #572

merged 1 commit into from
Jun 12, 2024

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Jun 12, 2024 •
edited
Loading

@rianhughes rianhughes requested review from IronGauntlets and thiagodeev and removed request for IronGauntlets June 12, 2024 11:15
thiagodeev
thiagodeev reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's indeed the only part of the code containing the 'price_in_strk' field, and the documentation is clear about the right field name.

@thiagodeev thiagodeev merged commit 819fa44 into main Jun 12, 2024
4 checks passed
@thiagodeev thiagodeev deleted the rianhughes/resource-marshal-err branch June 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagodeev thiagodeev thiagodeev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

price_in_fri incorrectly json encoded as price_in_strk
2 participants
@rianhughes @thiagodeev