add missing l1 transaction receipt field #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicr99
reviewed
Jun 14, 2024
rpc/transaction_test.go
Outdated
Comment on lines
342
to
344
| rec, ok := (txReceiptWithBlockInfo.TransactionReceipt).(InvokeTransactionReceipt) | ||
| require.True(t, ok) | ||
| rec2, ok := (txReceiptWithBlockInfo.TransactionReceipt).(InvokeTransactionReceipt) |
There was a problem hiding this comment.
Not sure I understand, is there a difference here between rec and rec2?
rpc/transaction_test.go
Outdated
Comment on lines
349
to
351
| rec, ok := (txReceiptWithBlockInfo.TransactionReceipt).(L1HandlerTransactionReceipt) | ||
| require.True(t, ok) | ||
| rec2, ok := (txReceiptWithBlockInfo.TransactionReceipt).(L1HandlerTransactionReceipt) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #575