Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #587

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Update README.md #587

merged 8 commits into from
Jul 9, 2024

Conversation

RV12R
Copy link
Contributor

@RV12R RV12R commented Jul 3, 2024

Update the "Run Examples" instructions in the readme.md #586

Update the "Run Examples" instructions in the readme.md NethermindEth#586
@thiagodeev thiagodeev self-requested a review July 3, 2024 17:27
@thiagodeev
Copy link
Collaborator

Thanks @RV12R!
I'll review it

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Requested changes
@RV12R RV12R requested a review from thiagodeev July 4, 2024 11:13
Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fourth example not included in the readme: deployContractUDC.
Let's add it to the "# Getting Started" section and to the "# Run Examples"

@thiagodeev
Copy link
Collaborator

Added deployContractUDC and a line correction.
@RV12R RV12R requested a review from thiagodeev July 5, 2024 05:36
@thiagodeev
Copy link
Collaborator

Great @RV12R!
One last thing before merge:

README.md Show resolved Hide resolved
@rianhughes rianhughes merged commit b09c605 into NethermindEth:main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants