chore::> Change input type of SignInvokeTransaction, SignDeployAccountTransaction, and SignDeclareTransaction
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
requested changes
Jul 11, 2024
|
Also, the code is failing in some CI test |
thiagodeev
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Hey @PsychoPunkSage, there are a few things that need fixing
|
|
||
| switch txn := tx.(type) { | ||
| case rpc.DeclareTxnV0: | ||
| // Due to inconsistencies in version 0 hash calculation we don't calculate the hash |
There was a problem hiding this comment.
Why did you do that? The description says about the V0 and you removed the V0 and applied the comment to the V1, you also removed the V1 hash calculation. Let's put them back
|
As discussed internally, we'll need first to create a function to calculate the class hash of legacy contract classes. It'll be done soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #590
This PR will Solve #590 pointer 2