Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed extension installation not executing from downloads page #16197

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fixed extension installation not executing from downloads page #16197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/extensions/mod_management/InstallManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,15 @@ class InstallManager {
return Bluebird.reject(
new ProcessCanceled('You need to select a game before installing this mod'));
}
if (installGameId === 'site' && baseName.toLowerCase().includes('extension')) {
// Assumption here is that anything we try to install from the "Modding Tools"/"site" domain
// that contains "extension" in its archive name is an extension... If a non-extension tool
// contains "extension" in its archive name... well, that's not good but there's nothing we can
// do without API providing a unique tag for us to identify Vortex extensions. (AFAIK we can't even query the existing tags from the website)
// Installation of non-Vortex tools with the extension basename will just install as a mod for
// the current game which I guess should be fine.
return Promise.resolve();
}
const state = api.getState();
const games = knownGames(state);
if (games.find(iter => iter.id === installGameId) === undefined) {
Expand Down