-
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
numpy 1.24.1 doesn't have a valid build for all the versions of python that BCML supports. 3.7 only has up until numpy 1.21.6, and you should both make sure that works and check the other python versions' availability/validity. |
Just a thought, but why not remove numpy from the dependencies? It doesn't seem to be used directly in bcml, and it seems that is what causing incompatibility with newer python versions. Older versions of python would just fetch the latest version that's compatible with them, no? |
I took that suggestion and ran with it. You are correct: without botw_havok, bcml no longer needs numpy. As well, if pywebview is updated to 4.0.0+ and pythonnet to 3.0.1+ then py37 continues to work fine. I suspect that all python versions above py37 should also work fine (which would finally resolve the endless python versioning and dependency war we have going on). If you can make those changes and test them for py38, that'll at least prove support for all python versions we explicitly support. If you want to also test py39 and py310, go ahead, but I'm willing to assume it'll work and hide behind "we're supporting what our readme says and also bcml is past EOL." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the changes I mentioned in my last comment. Just mentioning them explicitly here so they're easier to copy in.
The changes also should be made in requirements.txt, I'm just too lazy to make the other comments for it as well.
Changes made. I can confirm building with python 3.7, 3.8, and 3.10 worked fine. |
Does that mean no attempt for 3.9, or failed for 3.9? |
3.9 did fail, but something was wrong with my installation. I reinstalled, tried again, and it worked. |
Since botw_havok is no longer used, this removes it as a dependency while also updating numpy to its latest version, which can be used on newer python versions