Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Check if the icon is null #179

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Check if the icon is null #179

merged 2 commits into from
Jul 5, 2018

Conversation

raybooysen
Copy link
Contributor

Fixes #178

@raybooysen
Copy link
Contributor Author

raybooysen commented Jun 16, 2018

I don't quite get why this is failing on travis, node is throwing exceptions. I tested it out by downgrading to node 8 and the build works. Will take guidance on what you'd like to do: https://travis-ci.org/Nickersoft/push.js/builds/392980457?utm_source=github_status&utm_medium=notification

@Nickersoft
Copy link
Owner

First of all, thanks for the PR! Sorry this initially passed under the radar.

Damn.. it's a fairly well-known Node issue that is really recent. Has nothing to do with what you wrote. I think the build is failing on master. I'll look into getting a fix out today.

@raybooysen
Copy link
Contributor Author

The build passes if you force the node version to 8. I can do that as part of this PR?

@Nickersoft
Copy link
Owner

@raybooysen Ah yeah, I've recently discovered it's an issue with Node 10. You can force Travis to use the LTS version by updating the correct YAML property. I'd recommend v8.11.3, as I think that's the current LTS.

@raybooysen
Copy link
Contributor Author

Done, build green

@raybooysen
Copy link
Contributor Author

Is it possible to have this merged and released?

@Nickersoft
Copy link
Owner

@raybooysen Sorry! I think I saw your message a few days ago and meant to release and completely forgot. I'll merge it in now and draft a release when I get home.

@Nickersoft Nickersoft merged commit 690e3ae into Nickersoft:master Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants