Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loaders public #33

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Make loaders public #33

merged 4 commits into from
Mar 31, 2024

Conversation

Seldom-SE
Copy link
Contributor

Fixes #32.

NiklasEi
NiklasEi requested changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please add doc comments to the new public items.

@Seldom-SE
Copy link
Contributor Author

Also made PostcardAssetSaver public for the same reason

Please add doc comments to the new public items.

On it

@Seldom-SE
Copy link
Contributor Author

Done!

@Seldom-SE
Copy link
Contributor Author

Oh wait, I need PostcardAssetSaver to be constructable, because LoadTransformAndSave takes a value. I'll impl Default for it

@NiklasEi NiklasEi merged commit 9bd9d16 into NiklasEi:main Mar 31, 2024
4 checks passed
@Seldom-SE Seldom-SE deleted the pub_loaders branch March 31, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make loaders public
2 participants
@Seldom-SE @NiklasEi