-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pill 8 update #214
Pill 8 update #214
Conversation
NB Darwin variant still outstanding.
to avoid collision & confusion with standard function.
not tested
renaming to mkDerivation
now using derivation instead of pkgs.stdenv.mkDerivation
@zmitchell would be great if you can confirm that the mac example is sound. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-15-documentation-team-meeting-notes-55/29161/1 |
The |
Co-authored-by: Zach Mitchell, PhD <zmitchell@fastmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though (and this is not a blocker) I wonder why the approach is to inherit
dependencies first rather than going straight to including them in the buildInputs
; it happens in Pill 7 here. All we really need in this case is the paths to those dependencies included in PATH
, as is done here in generic-builder.txt.
This and the surrounding Pills are great targets for refactoring into tutorials for the Learning Journey Working Group. In particular, there is material here that addresses needs of NixOS/nix.dev#601 and NixOS/nix.dev#602
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-10-documentation-team-meeting-notes-62/30291/1 |
This is a general refresh of the pill, including using the with statements with a smaller scope (better practice)
What I know is not 100%:
The naming - mymkDerivation - I wanted to avoid collision and confusion with with pkgs.stdenv.mkDerivation.The Darwin part - I haven't tested those adaptions as I am on WSL.