-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages: add default meta.mainProgram #176398
Conversation
Because perl packages are prefixed with the perl version, it means that the `lib.getExe` heuristic will never point to the binary name. So we provide the meta.mainProgram that overrides that, using the original pname or parsed name. It's not perfect but should yield better results already.
Thanks for letting me know. I removed the individual package fixes to keep this PR focused on the default mainProgram change. I will merge this so the other PR can be rebased on top, I believe he will be able to remove a bunch of overrides. |
This will definitely get This change is explicitly setting the I don't have any real experience with |
Sounds good, if you do that change then mine can be reverted. I'm not a perl maintainer so I was only looking for a minimal change. |
This reverts commit ff7b216.
Description of changes
Because perl packages are prefixed with the perl version, it means that
the
lib.getExe
heuristic will never point to the binary name. So weprovide the meta.mainProgram that overrides that, using the original
pname or parsed name. It's not perfect but should yield better results
already.
If you're looking for an example:
nix run .#pgbadger
used to be brokenThings done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes