python310Packages.pillow: 9.4.0 -> 9.5.0 #228493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The header issue has been fixed upstream in python-pillow/Pillow#7069. |
|
Also you have a typo in the commit title: it should be python310Packages |
roblabla
force-pushed
the
update-pillow-9.5.0
branch
from
aaaa52b
to
817715d
Compare
roblabla
force-pushed
the
update-pillow-9.5.0
branch
from
817715d
to
d0f2ea3
Compare
roblabla
changed the title
Did you consider just fetching this commit instead? This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people. |
12 tasks
asymmetric
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Agreed, this should just apply the patch from python-pillow/Pillow#7069
|
As this seems stale I created #241913 to supersede it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pillow changelog: https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst#950-2023-04-01
Note that this MR reverts an upstream commit (04cf5e2cfc5dc1676efd9f5c8d605ddfccb0f9ee) as it prevents pillow from finding its native dependencies during the build. We should probably try to fix the underlying issue, but I'm having trouble understanding what the patch even does.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)