Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages: Add OpenStack Octavia client and Neutron bindings #322593

Merged
merged 7 commits into from
Sep 1, 2024

Conversation

Vinetos
Copy link
Member

@Vinetos Vinetos commented Jun 26, 2024

Description of changes

Add python-octaviaclient in nix ecosystem.
The documentation cannot be built for now as sphinxcontrib-svg2pdfconverter does not exist yet.
I am marking this MR as Draft as I am not fully confident about this.

Closes #320529

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Vinetos Vinetos marked this pull request as draft June 26, 2024 07:40
@Vinetos Vinetos changed the title Draft: pythonPackages.python-octaviaclient init at 3.7.0 pythonPackages.python-octaviaclient init at 3.7.0 Jun 26, 2024
@Vinetos
Copy link
Member Author

Vinetos commented Jun 26, 2024

I am not able to run commands as openstack loadbalancer ....

Here is my shell.nix :

let
  pkgs = import <nixpkgs> {};
in pkgs.mkShell {
  packages = [
    (pkgs.python3.withPackages (python-pkgs: [
      # select Python packages here
      python-pkgs.python-openstackclient
      (pkgs.callPackage ./pkgs/development/python-modules/python-octaviaclient/default.nix)
    ]))
  ];
}
➜ openstack loadbalancer
openstack: 'loadbalancer' is not an openstack command. See 'openstack --help'.

What am I doing wrong here ?

@Vinetos
Copy link
Member Author

Vinetos commented Jun 28, 2024

I saw that OpenCtack client use the entrypoint mecanism to discover and load extension.
I have a lot to learn about Python packaging so, I do not know if I can but as your the the last member of the OpenStack team, could I have some help @SuperSandro2000

@SuperSandro2000
Copy link
Member

I saw that OpenCtack client use the entrypoint mecanism to discover and load extension.

I haven't worry about that yet.

I have a lot to learn about Python packaging so, I do not know if I can but as your the the last member of the OpenStack team,

We could probably add a top-level entry similar to swift.

@Vinetos Vinetos force-pushed the octaviaclient branch 2 times, most recently from 01e7a10 to 0eb8b92 Compare August 5, 2024 07:26
@ofborg ofborg bot requested a review from anthonyroussel August 5, 2024 08:14
@Vinetos
Copy link
Member Author

Vinetos commented Aug 5, 2024

Result of nixpkgs-review run on x86_64-linux 1

14 packages built:
  • openstackclient-full
  • openstackclient-full.dist
  • python311Packages.doc8
  • python311Packages.doc8.dist
  • python311Packages.os-client-config
  • python311Packages.os-client-config.dist
  • python311Packages.osprofiler
  • python311Packages.osprofiler.dist
  • python311Packages.python-neutronclient
  • python311Packages.python-neutronclient.dist
  • python311Packages.python-octaviaclient
  • python311Packages.python-octaviaclient.dist
  • python312Packages.doc8
  • python312Packages.doc8.dist

@anthonyroussel
Copy link
Member

@Vinetos Hello!

Unfortunately, there are some merge conflicts with your branch.

Once these merge conflicts are resolved, maybe we can try to submit your PR in the PRs ready for review Discourse thread to try to find someone with merge rights.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM and I can merge it

@Vinetos
Copy link
Member Author

Vinetos commented Aug 30, 2024

Ready :D

Result of nixpkgs-review run on x86_64-linux 1

14 packages built:
  • openstackclient-full
  • openstackclient-full.dist
  • python311Packages.doc8
  • python311Packages.doc8.dist
  • python311Packages.os-client-config
  • python311Packages.os-client-config.dist
  • python311Packages.osprofiler
  • python311Packages.osprofiler.dist
  • python311Packages.python-neutronclient
  • python311Packages.python-neutronclient.dist
  • python311Packages.python-octaviaclient
  • python311Packages.python-octaviaclient.dist
  • python312Packages.doc8
  • python312Packages.doc8.dist

Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 322593 run on aarch64-darwin 1

14 packages built:
  • openstackclient-full
  • openstackclient-full.dist
  • python311Packages.doc8
  • python311Packages.doc8.dist
  • python311Packages.os-client-config
  • python311Packages.os-client-config.dist
  • python311Packages.osprofiler
  • python311Packages.osprofiler.dist
  • python311Packages.python-neutronclient
  • python311Packages.python-neutronclient.dist
  • python311Packages.python-octaviaclient
  • python311Packages.python-octaviaclient.dist
  • python312Packages.doc8
  • python312Packages.doc8.dist

Result of nixpkgs-review pr 322593 run on x86_64-linux 1

14 packages built:
  • openstackclient-full
  • openstackclient-full.dist
  • python311Packages.doc8
  • python311Packages.doc8.dist
  • python311Packages.os-client-config
  • python311Packages.os-client-config.dist
  • python311Packages.osprofiler
  • python311Packages.osprofiler.dist
  • python311Packages.python-neutronclient
  • python311Packages.python-neutronclient.dist
  • python311Packages.python-octaviaclient
  • python311Packages.python-octaviaclient.dist
  • python312Packages.doc8
  • python312Packages.doc8.dist

@SuperSandro2000 SuperSandro2000 merged commit d719f51 into NixOS:master Sep 1, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: python-octaviaclient
6 participants