-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/snapserver: update module to work with snapcast 0.20 #94071
Conversation
For some reason I'm always gettingthe renamed trace, even though I'm not using the
|
I'll try to squeeze a review in later today. |
@tobim I also believe we need to add a static group for snapcast, since we need to allow other users like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also believe we need to add a static group for snapcast, since we need to allow other users like
mpd
to write to the pipe at/run/snapserver/mpd
.
The server always creates the pipe with write access for all:
https://github.com/badaix/snapcast/blob/d44f3be4edee76494cecb1c28caf46969f3ba15c/server/streamreader/pipe_stream.cpp#L50
If we need access control for that it should be implemented upsteam.
|
||
in { | ||
imports = [ | ||
(mkRenamedOptionModule [ "services" "snapserver" "controlPort"] [ "services" "snapserver" "tcp" "port" ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust line 282 to fix the deprecation warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Good catch.
Indeed, thanks for the pointer to the snapcast source code. |
@GrahamcOfBorg test snapcast |
Checks - if all configured ports are listened on - if all pipes for multiple streams get set up - if rpc interaction is possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works with mpd
.
Thanks for reviewing this! |
Motivation for this change
With the update of snapcast from 0.15 to 0.20 in #90294 I inadvertently broke the module, since the CLI parameters changed quite a bit.
This should rectify and even improve the situation.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)