We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CrostonClassic has a required argument level:
level
statsforecast/statsforecast/models.py
Line 3596 in 444f01e
However,
predict_in_sample()
Hence, it seems like it should be either
def predict_in_sample(self, level: Optional[Tuple[int]] = None):
to be consistent with other methods that use level argument.
Or
def predict_in_sample(self):
to be consistent with other not implemented methods.
The text was updated successfully, but these errors were encountered:
This should be def predict_in_sample(self, level: Optional[Tuple[int]] = None):.
@jaymanalastas, would you like to fix?
Sorry, something went wrong.
kvnkho
Successfully merging a pull request may close this issue.
CrostonClassic has a required argument
level
:statsforecast/statsforecast/models.py
Line 3596 in 444f01e
However,
level
as a required argument inpredict_in_sample()
method.Hence, it seems like it should be either
to be consistent with other methods that use
level
argument.Or
to be consistent with other not implemented methods.
The text was updated successfully, but these errors were encountered: