Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add predict_in_sample to intermittent models #764

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jan 16, 2024

Adds the predict_in_sample method to the intermittent models (ADIDA, IMAPA, TSB and Croston).

Fixes #491
Fixes #664

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review January 16, 2024 23:29
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! LGTM🚀

@jmoralez jmoralez merged commit 7e69091 into main Jan 21, 2024
17 checks passed
@jmoralez jmoralez deleted the fitted-intermittent branch January 21, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants