Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MSTL where trend forecaster supports level #625

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Aug 25, 2023

Ensures that the MSTL model doesn't need the prediction_intervals argument when the trend forecaster supports producing prediction intervals.

Fixes #622

@jmoralez jmoralez added the fix label Aug 25, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title fix mstl where trend forecaster supports level fix MSTL where trend forecaster supports level Aug 25, 2023
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmoralez! Thanks for the fix. I left a comment. Let me know wdyt :)

statsforecast/models.py Outdated Show resolved Hide resolved
@AzulGarza AzulGarza self-requested a review August 30, 2023 00:35
@jmoralez jmoralez merged commit d93001f into main Sep 19, 2023
19 checks passed
@jmoralez jmoralez deleted the mstl-trend-interval branch September 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[statsforecast, MSTL]: Prediction Interval throw error
2 participants