Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mstl_decomposition function #701

Merged
merged 3 commits into from
Nov 27, 2023
Merged

add mstl_decomposition function #701

merged 3 commits into from
Nov 27, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 15, 2023

Adds the feature_engineering module which will hold utilities to help generate features to be used in downstream models. Right now we're adding the mstl_decomposition function, which adds the trend and season component of each serie as well as a guide on how to use it.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AzulGarza
Copy link
Member

I'm loving this already😍

@jmoralez jmoralez changed the title add feature_engineering module add mstl_decomposition function Nov 15, 2023
@jmoralez jmoralez marked this pull request as ready for review November 15, 2023 22:30
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jmoralez jmoralez merged commit 67b435e into main Nov 27, 2023
17 checks passed
@jmoralez jmoralez deleted the feat-eng branch November 27, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants