Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate model alias to fallback model in fit #846

Merged
merged 1 commit into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nbs/src/core/core.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@
" except Exception as error:\n",
" if fallback_model is not None:\n",
" new_fallback_model = fallback_model.new()\n",
" new_fallback_model.alias = model.alias\n",
" fm[i, i_model] = new_fallback_model.fit(y=y, X=X)\n",
" else:\n",
" raise error\n",
Expand Down
1 change: 1 addition & 0 deletions statsforecast/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def fit(self, models, fallback_model=None):
except Exception as error:
if fallback_model is not None:
new_fallback_model = fallback_model.new()
new_fallback_model.alias = model.alias
fm[i, i_model] = new_fallback_model.fit(y=y, X=X)
else:
raise error
Expand Down
Loading