support progress bar in parallel forecast #849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
forecast
method to use aconcurrent.futures.ProcessPoolExecutor
which processes series one at a time instead of chunks of them. This allows two things:I ran the following experiment in a c5.4xlarge instance to compare the current version versus the one in this PR to verify that there isn't a slowdown:
Click to expand
and it took 1min 36s (current main) vs 1min 32s (this PR).