feat(sponsorship): add more details to sponsorship events #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 73.81% 73.98% +0.16%
==========================================
Files 47 47
Lines 9017 9074 +57
==========================================
+ Hits 6656 6713 +57
Misses 2361 2361 ☔ View full report in Codecov by Sentry. |
Douglasacost
approved these changes
Nov 14, 2023
| users: Vec<T::AccountId>, | ||
| fee_quota: BalanceOf<T>, | ||
| reserve_quota: BalanceOf<T>, | ||
| }, | ||
| /// Event emitted when a sponsor_me call has been successful indicating the reserved amount | ||
| Sponsored { paid: BalanceOf<T>, repaid: BalanceOf<T> }, |
There was a problem hiding this comment.
@Douglasacost paid is how much was borrowed from the sponsor at the beginning of this call and repaid means how much debt was payed off from the user's account at the end of this call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra detail in the events is not going to impact the cost of the corresponding extrinsics sensibly. However they help with the performance of the indexers such as Subquery which follow the events and are better off just doing that and not needing to query a value from a node.