Remove persisting of service account token #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ci: upgrade to go-1.17.2
…e or file, Rename internally into kubeconfig DisableLocalCaJwt -> DisableLocalCa Rename DisableLocalCaJwt -> DisableLocalCa for deprecation on API side. Currently looking into the usage for the config key: as this is always used now. Working onto tests.
|
@Nordix For clarification on the "draft" status of the PR. Due to your PR being the base for my changes, I created my PR here in case your PR gets reviewed by Hashicorp. After this point, I will (if accepted) move this PR to the Hashicorp repository. I might close the PR and reopen it later over at the Vault repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaced persisting the persisting the service account token into the kubeconfig by always using the cached service account token file reader.
Removed persisting of the
token_reviewer_jwtconfiguration field for kubeconfig.Renamed DisableLocalCAJwt for DisableLocalCa, to deprecate the old
disable_local_ca_jwtand replace withdisable_local_ca. This is due to the local JWT token no longer being replacable.Related Issues/Pull Requests
[ ] Issue #12937
[ ] PR #122
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Check initialisation sequence for test.
backend.go#initializenot called[x] Backwards compatible
[ ] Check if superseded by Issue #12951