Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Oh, no!" error page when uploading a package with an invalid license URL #1682

Closed
claycompton opened this issue Oct 26, 2013 · 4 comments · Fixed by #1743
Closed

"Oh, no!" error page when uploading a package with an invalid license URL #1682

claycompton opened this issue Oct 26, 2013 · 4 comments · Fixed by #1743
Assignees

Comments

@claycompton
Copy link

To repro:

  1. Create a package with an invalid license URL. I was able to reproduce this behavior with a URL that was over 4000 chars long.
  2. Attempt to upload the package using the Gallery UI.

Result: After the initial package upload, you'll receive a WSOD. Investigating the error logs reveals that we don't handle the EntityException that gets thrown. For the full stack trace and error details, see https://qa.nugettest.org/Admin/Errors.axd/detail?id=3774.

Expected: Package validation errors should be presented to the user ideally in a way that resembles form validation errors. In any case, though, we shouldn't white-screen.

@TimLovellSmith
Copy link
Member

If the only invalid case is an url that is over 4000 chars long I'm going to vote won't fix.

@analogrelay
Copy link
Contributor

I agree with @claycompton here... We use validation for a reason. If it's not working, we need to fix it.

@TimLovellSmith
Copy link
Member

Validation works. This is just an edge case. URLs don't normally run 4000 characters, so I think the rational allocation of bug to milestone is this goes to up for grabs.

@ghost ghost assigned analogrelay Oct 29, 2013
@analogrelay
Copy link
Contributor

We need to validate all package metadata to ensure it matches the requirements of the database fields. For example, if I upload a package with a bogus version, what happens? etc.

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants