Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateOnlineDatabaseBackupJob throws if TargetDatabase is null #1901

Closed
analogrelay opened this issue Feb 19, 2014 · 3 comments · Fixed by NuGet/NuGet.Services.Work#10
Closed

CreateOnlineDatabaseBackupJob throws if TargetDatabase is null #1901

analogrelay opened this issue Feb 19, 2014 · 3 comments · Fixed by NuGet/NuGet.Services.Work#10
Assignees
@analogrelay
Milestone
v3.0.2

Comments

@analogrelay
Copy link
Contributor

[Ported from https://github.com/NuGet/NuGetApi/issues/22]

If TargetServer is specified but TargetDatabase is null, CreateOnlineDatabaseBackupJob throws. The simple workaround is to specify a value for TargetDatabase, but this should be fixed.

Test Notes

Re-create the BackupLegacyDatabase job WITHOUT the TargetDatabase payload parameter. If that parameter is not specified, it should use the database specified by the "Initial Catalog" value in the Connection String referred to by TargetServer
@analogrelay analogrelay added this to the v3.0.1 milestone Feb 19, 2014
@analogrelay analogrelay self-assigned this Feb 19, 2014
@analogrelay
Copy link
Contributor Author

Seems to already be fixed :)

@analogrelay
Copy link
Contributor Author

NOTE: I don't think there was a pull request for this in the end (my bad), but the change has been made and can still be verified.

@analogrelay analogrelay modified the milestones: v3.0.2, v3.0.1 Feb 28, 2014
@analogrelay
Copy link
Contributor Author

Nope, not fixed.

@analogrelay analogrelay reopened this Feb 28, 2014
@analogrelay analogrelay mentioned this issue Mar 4, 2014
Closed
analogrelay added a commit to NuGet/NuGet.Services.Work that referenced this issue Mar 7, 2014
@analogrelay
Fix NuGet/NuGetGallery#1901 by adding ye olde null-check
78e1f08
@analogrelay analogrelay mentioned this issue Mar 7, 2014
Merged
analogrelay added a commit to NuGet/NuGet.Services.Work that referenced this issue Mar 10, 2014
@analogrelay
Merge pull request #10 from NuGet/anurse/1901-targetdatabasenull
21ab86a 
Fix NuGet/NuGetGallery#1901 by adding ye olde null-check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@analogrelay analogrelay

Labels
None yet
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging a pull request may close this issue.

Fix NuGet/NuGetGallery#1901 by adding ye olde null-check NuGet/NuGet.Services.Work
1 participant
@analogrelay