Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with highlight-js 11.10.0 #476

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

davidtaylorhq
Copy link
Contributor

The change in highlightjs/highlight.js@c813674 affected our detection of the css rule, which is used as a base for the hbs tagged-template-literal highlighting.

Copy link

stackblitz bot commented Jul 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: c6bf513

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
highlightjs-glimmer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidtaylorhq davidtaylorhq changed the title Fix for highlight-js 11.10.0 Fix compatibility with highlight-js 11.10.0 Jul 8, 2024
davidtaylorhq added a commit to discourse/discourse-highlightjs-glimmer that referenced this pull request Jul 8, 2024
The change in highlightjs/highlight.js@c813674 affected our detection of the css rule, which is used as a base for the `hbs` tagged-template-literal highlighting.
davidtaylorhq added a commit to discourse/discourse-highlightjs-glimmer that referenced this pull request Jul 8, 2024
Copy link
Owner

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you!

@NullVoxPopuli NullVoxPopuli merged commit 64120a7 into NullVoxPopuli:main Jul 8, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants