[17.0][MIG] account_payment_order: Migration to 17.0 #1208

ramiadavid · 2024-01-13T09:13:40Z

No description provided.

pedrobaeza · 2024-01-13T14:14:21Z

/ocabot migration account_payment_order

HaraldPanten · 2024-02-26T17:51:12Z

@ramiadavid Could you rebase, please? I'd like to test the module in runboat.

THX.

…the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order - add wizard of selection of move lines to pay

* IMP: prevent deleting a move-line that is linked to a payment order line * FIX: better filtering of move lines already included in open payment order

Take into account all the remaining remarks of Frederic Clementi dated May 30: - see multi-currency amounts in the wizard to add transaction lines - add help msg on bank payment lines

* IMP: extensibility of _prepare_move Pass the list of bank lines to _prepare_move so it is possible to customize the move (eg it's name) based on the lines being paid. * FIX: payment order: add missing onchange dependencies in move selection wizard

* Fix crash when selecting a customer that has a direct debit payment mode but no mandate * Hide many fields when payment_order_ok is False on a payment_mode * Fix payment line communication when the move line is not linked to an invoice (problem found when porting donation_debit_debit to v9) * For the communication field, if self.move_id.ref is False, fallback on self.move_id.name

fixes OCA#277

Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)

* FIX: Bug OCA#353 crash when selecting a payment mode that has a variable link to a bank account * FIX: Add 'post_move' option on account.payment.mode with default True, to keep the previous behavior * IMP: Explicit error when bank account is missing on bank journal * IMP: Add field default_date_prefered on payment mode.

…ent order + allow to cancel an uploaded payment order

* Restrict the deletion of bank payment line * Add test_cancel_payment_order

…nt_order_order_communication_direct() method. Related to: OCA#1178

ramiadavid · 2024-02-26T21:20:50Z

@HaraldPanten done

HaraldPanten

1- Create a payment/debit order.
2- Click on "Create Payment Lines form Journal Items" button.

An error occured:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1765, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1792, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1996, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 722, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 24, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/web/models/models.py", line 953, in onchange
    if cmd[0] in (Command.UPDATE, Command.LINK):
TypeError: 'int' object is not subscriptable

The above server error caused the following client error:
OwlError: An error occured in the owl lifecycle (see this Error's "cause" property)
    at handleError (http://oca-bank-payment-17-0-pr1208-0a4c4115d4e1.runboat.odoo-community.org/web/assets/179c946/web.assets_web.min.js:916:101)
    at App.handleError (http://oca-bank-payment-17-0-pr1208-0a4c4115d4e1.runboat.odoo-community.org/web/assets/179c946/web.assets_web.min.js:1542:29)
    at ComponentNode.initiateRender (http://oca-bank-payment-17-0-pr1208-0a4c4115d4e1.runboat.odoo-community.org/web/assets/179c946/web.assets_web.min.js:1006:19)

Caused by: RPC_ERROR: Odoo Server Error
    at makeErrorFromResponse (http://oca-bank-payment-17-0-pr1208-0a4c4115d4e1.runboat.odoo-community.org/web/assets/179c946/web.assets_web.min.js:2875:163)
    at XMLHttpRequest.<anonymous> (http://oca-bank-payment-17-0-pr1208-0a4c4115d4e1.runboat.odoo-community.org/web/assets/179c946/web.assets_web.min.js:2879:13)

Tested in runboat.

Could you check the main options of the module? THX!

ramiadavid · 2024-02-28T16:49:41Z

@HaraldPanten Fixed

HaraldPanten

Functional review tested in runboat. Seems to be OK 👍.

account_payment_order/tests/test_payment_order_outbound.py

account_payment_order/models/account_move.py

ramiadavid · 2024-02-28T20:05:07Z

account_payment_order/models/account_payment_order.py

-                # Write requested_date on 'date' field of payment line
-                # norecompute is for avoiding a chained recomputation
-                # payment_line_ids.date
-                # > payment_line_ids.amount_company_currency
-                # > total_company_currency
-                with self.env.norecompute():
-                    payline.date = requested_date
+                payline.date = requested_date


@pedrobaeza I have removed this because in v17 it is obsolete and is not doing anything, but I am not sure how to check if it is a problem.

Thanks for pointing it. I agree it's not needed. This is an ORM glitch combined with old onchanges. Now all the compute stuff is way more robust and don't require these hacks.

pedrobaeza

Thanks for the work.

/ocabot merge nobump

OCA-git-bot · 2024-02-29T11:24:42Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1208-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2024-02-29T11:31:13Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1208-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2024-02-29T11:31:13Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1208-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2024-02-29T11:32:07Z

/ocabot merge nobump

OCA-git-bot · 2024-02-29T11:32:14Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1208-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-02-29T11:38:21Z

Congratulations, your PR was merged at ccee522. Thanks a lot for contributing to OCA. ❤️

ramiadavid mentioned this pull request Jan 13, 2024

Migration to version 17.0 #1173

Open

14 tasks

ramiadavid force-pushed the 17.0-mig-account_payment_order branch 2 times, most recently from 182f9c8 to 83f7102 Compare January 13, 2024 09:19

ramiadavid marked this pull request as ready for review January 13, 2024 09:22

OCA-git-bot added this to the 17.0 milestone Jan 13, 2024

rlemeur approved these changes Feb 26, 2024

View reviewed changes

alexis-via and others added 22 commits February 26, 2024 22:06

[FIX+IMP] account_payment_order: 2 things:

e8a1881

* IMP: prevent deleting a move-line that is linked to a payment order line * FIX: better filtering of move lines already included in open payment order

Add support for multi-currency in the generation of the account move.

714aa03

Take into account all the remaining remarks of Frederic Clementi dated May 30: - see multi-currency amounts in the wizard to add transaction lines - add help msg on bank payment lines

[IMP] account_payment_order: Remove useless migration script

fbb5e54

Move the account_payment_mode ir.rule in account_payment_mode module

ded9f15

[IMP] set partner on offsetting account move line if possible

c9d0a51

fixes OCA#277

Reactivate company rules in account_payment_order

f123826

Port almost all modules to v10 (OCA#305)

7444be2

Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)

[FIX] account_payment_order: Use 'index' instead of 'select'

0ccd35c

Remove internal_type=other restriction for transfer account (OCA#311)

3b67901

Creation/Modification of bank info only for Account Payment group

2eecdcd

[FIX] fill date instead off maturity date on account move line generated

0152044

Fix 2 issues on form view for payment order

e47a566

[IMP] account_payment_order: Don't allow deletion of an uploaded paym…

132e991

…ent order + allow to cancel an uploaded payment order

[IMP] account_payment_order: Restriction + tests

e1352c9

* Restrict the deletion of bank payment line * Add test_cancel_payment_order

[FIX] account_payment_order: Adapt test to v10

d22e000

[IMP] account_payment_order: select partner bank account automatically.

22e5fd4

[10.0]Fix payment method onchange with multicompany (OCA#374)

5ffe99a

[ADD] description field for payment order

d863ee9

victoralmau and others added 2 commits February 26, 2024 22:06

[FIX] account_payment_order: Always return a string in the _get_payme…

d882d8e

…nt_order_order_communication_direct() method. Related to: OCA#1178

[IMP] account_payment_order: pre-commit auto fixes

eb14ae2

ramiadavid force-pushed the 17.0-mig-account_payment_order branch from 83f7102 to 0a4c411 Compare February 26, 2024 21:07

HaraldPanten requested changes Feb 28, 2024

View reviewed changes

ramiadavid force-pushed the 17.0-mig-account_payment_order branch 2 times, most recently from 71b997f to f86118e Compare February 28, 2024 16:36

HaraldPanten approved these changes Feb 28, 2024

View reviewed changes

OCA-git-bot added the approved label Feb 28, 2024

pedrobaeza reviewed Feb 28, 2024

View reviewed changes

account_payment_order/tests/test_payment_order_outbound.py Outdated Show resolved Hide resolved

account_payment_order/models/account_move.py Outdated Show resolved Hide resolved

[MIG] account_payment_order: Migration to 17.0

1f9fb94

ramiadavid force-pushed the 17.0-mig-account_payment_order branch from f86118e to 60e8150 Compare February 28, 2024 20:01

ramiadavid commented Feb 28, 2024

View reviewed changes

ramiadavid force-pushed the 17.0-mig-account_payment_order branch from 60e8150 to 1f9fb94 Compare February 28, 2024 20:08

pedrobaeza approved these changes Feb 29, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 29, 2024

OCA-git-bot added a commit that referenced this pull request Feb 29, 2024

Merge PR #1208 into 17.0

798f686

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Feb 29, 2024

OCA-git-bot added the bot is merging ⏳ label Feb 29, 2024

OCA-git-bot merged commit b8af5ba into OCA:17.0 Feb 29, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 29, 2024

ramiadavid deleted the 17.0-mig-account_payment_order branch April 7, 2024 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_payment_order: Migration to 17.0 #1208

[17.0][MIG] account_payment_order: Migration to 17.0 #1208

ramiadavid commented Jan 13, 2024

pedrobaeza commented Jan 13, 2024

HaraldPanten commented Feb 26, 2024

ramiadavid commented Feb 26, 2024

HaraldPanten left a comment •

edited

Loading

ramiadavid commented Feb 28, 2024

HaraldPanten left a comment

ramiadavid Feb 28, 2024

pedrobaeza Feb 29, 2024

pedrobaeza left a comment

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

pedrobaeza commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

[17.0][MIG] account_payment_order: Migration to 17.0 #1208

[17.0][MIG] account_payment_order: Migration to 17.0 #1208

Conversation

ramiadavid commented Jan 13, 2024

pedrobaeza commented Jan 13, 2024

HaraldPanten commented Feb 26, 2024

ramiadavid commented Feb 26, 2024

HaraldPanten left a comment • edited Loading

Choose a reason for hiding this comment

ramiadavid commented Feb 28, 2024

HaraldPanten left a comment

Choose a reason for hiding this comment

ramiadavid Feb 28, 2024

Choose a reason for hiding this comment

pedrobaeza Feb 29, 2024

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

pedrobaeza commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

OCA-git-bot commented Feb 29, 2024

HaraldPanten left a comment •

edited

Loading