Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_banking_mandate: Migration to 17.0 #1228

Merged
merged 64 commits into from
Mar 6, 2024

Conversation

ramiadavid
Copy link
Contributor

No description provided.

pedrobaeza and others added 30 commits March 2, 2024 11:33
* Bug OCA#96 bad use of new API
* [Usability] mandates: search by reference, add group_by, add seq type in tree view
* Add scheme in mandate tree+search view
* Replace tabs by spaces in mandate views
* account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format
* Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more
Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer
Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule.
Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers
* Bump version numbers
* es translations
* Add creditor identifier field to report mandate.
* Translate.
* Split basic and sepa mandate
* Use api.multi instead
* Make format field required
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided

Using same method as in upstream, mandate is filled on invoice creation if no
one is provided. This way, we don't need to install account_banking_mandate_sale
if we don't want to handle several mandates at sales level.
…date + Add valid_mandate field and fix onchange

(cherry picked from commit 25d2e4d)
* Fix tests due to upstream change

  Odoo has added a constraint for avoiding a company currency change if there
  are move lines, making these tests to fail, as the currency is changed to EUR.

  With this commit, we create a new company with EUR currency for avoiding the
  problem.

  This commit also changes account_banking_mandate for not duplicating mandate
  number, as it was detected during the test creation.

  Similar to 1f8e345
* Avoid errors in tests when run with other modules
* More adaptations to make tests to work properly

  All these problems comes from using demo data.
So multi-company environment won't work correctly.
* Adapted test
* Removed unneeded constraint
* Fixed view for accessibility
The searches in the constraint should be done as sudo since it should not depend on the access of the user
It allows a user with no access on payment line to open mandates
@ramiadavid ramiadavid mentioned this pull request Mar 2, 2024
14 tasks
@ramiadavid ramiadavid changed the title [17.0][MIG] account_banking_mandate): Migration to 17.0 [17.0][MIG] account_banking_mandate: Migration to 17.0 Mar 2, 2024
@ramiadavid ramiadavid force-pushed the 17.0-mig-account_banking_mandate branch from 3e2fe06 to 6803b29 Compare March 2, 2024 11:23
@ramiadavid ramiadavid marked this pull request as ready for review March 2, 2024 11:23
@pedrobaeza
Copy link
Member

/ocabot migration account_banking_mandate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 2, 2024
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review in runboat. Seems to be OK

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please convert the setUp to setUpClass to improve the performance of the tests?

@ramiadavid ramiadavid force-pushed the 17.0-mig-account_banking_mandate branch from 6803b29 to fe933ab Compare March 5, 2024 20:20
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1228-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 09e28a1 into OCA:17.0 Mar 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37cc3dd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.