Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] delivery_mrw: Avoid test error #3713

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Sep 9, 2024

The staging server has a new check for asking for a phone and number of packages:

MRW Error: 1) La fecha de recogida se cambió a 09/09/2024.2) La fecha de recogida solicitada es 09/09/2024.3) Se debe indicar el teléfono de contacto del destinatario4) La Etiqueta se imprimirá con RF (Revisar en Franquicia) al ser un servicio no válido entre origen y destino.5) Debe indicar el número de bultos del envío)

so let's fill them in the test partner for avoiding it.

The tests has been also refactored a bit for not duplicating code.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 9, 2024
The staging server has a new check for asking for a phone and number of
packages:

```
MRW Error: 1) La fecha de recogida se cambió a 09/09/2024.2) La fecha de recogida solicitada es 09/09/2024.3) Se debe indicar el teléfono de contacto del destinatario4) La Etiqueta se imprimirá con RF (Revisar en Franquicia) al ser un servicio no válido entre origen y destino.5) Debe indicar el número de bultos del envío)
```

so let's fill them in the test partner for avoiding it.

The tests has been also refactored a bit for not duplicating code.
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3713-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a13a903 into OCA:14.0 Sep 9, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 201fb01. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-fix-delivery_mrw-ci branch September 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants