Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our tooling to support Odoo 18.0 #628

Open
2 of 28 tasks
sbidoul opened this issue Sep 12, 2024 · 17 comments
Open
2 of 28 tasks

Update our tooling to support Odoo 18.0 #628

sbidoul opened this issue Sep 12, 2024 · 17 comments

Comments

@sbidoul
Copy link
Member

sbidoul commented Sep 12, 2024

Improvements we may want to do


See #582 for links to similar PRs for 17.0.

@simahawk
Copy link
Contributor

generate 18.0 branches (oca-create-branch), using the bot account

I'd rather add another tool on https://github.com/OCA/repo-maintainer as we need to add a branch to all repos of https://github.com/OCA/repo-maintainer-conf.

I could have a look at that. Then we can trash oca-create-branch IMO, unless you see any reason to keep it.

@pedrobaeza
Copy link
Member

I have assigned to me the OCB first part and the OpenUpgrade one.

@simahawk
Copy link
Contributor

set OCB 18.0 branch as default

same for this -> we must use the repo-maintainer. I'll include an option in the new tool mentioned above.

@pedrobaeza I take over this one if ok for you

@legalsylvain
Copy link
Contributor

Hi @sbidoul. Thanks for enumerating all the tasks to do.
The majority of tasks cannot be performed, as version 18.0 has not been released but as soon as 18.0 is released, we can go forward.
The last year, the release was done october 26, 2023 : (odoo/odoo@dd05f0a) 13 days before the Odoo days. (8 - 10 November 2023)

@sbidoul
Copy link
Member Author

sbidoul commented Sep 12, 2024

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: #541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

@pedrobaeza
Copy link
Member

@simahawk OK

@legalsylvain I predict this year the date will be more constrained, as they still have some big things to merge (for example, company dependent fields to JSON - let's hope it enters this version -), but maybe they still create the branch on advance even if not completed as a favor to the community.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 12, 2024

@legalsylvain it's true some tasks can't be done yet. PRs can be prepared, though.

But more importantly there are the improvements mentioned at the beginning that can be worked on if we want to address them.

@simahawk
Copy link
Contributor

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: #541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

hmm the repo-maintainer will bootstrap the branch w/o that tool. We have to find a different way likely. I'll have a look, thanks for the pointer.

@simahawk
Copy link
Contributor

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: #541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

hmm the repo-maintainer will bootstrap the branch w/o that tool. We have to find a different way likely. I'll have a look, thanks for the pointer.

I had a look at your work but I think we don't need it anymore. Please see #541 (comment)
If that's correct, here we have the new tool to manage branches and here the result for v18

@pedrobaeza
Copy link
Member

I have added a point for the migration guide.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 13, 2024

I have added a point for the migration guide.

@pedrobaeza was that not the third item already?

@pedrobaeza
Copy link
Member

Ouch, I didn't see it...

@PabloEForgeFlow
Copy link

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through OCA/oca-ci#10 and I think I could do that, if nobody's working on it currently.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 13, 2024

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through OCA/oca-ci#10 and I think I could do that, if nobody's working on it currently.

@PabloEForgeFlow cool, that is most welcome. Just checking if @rousseldenis was not planning to do the same.

@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented Sep 13, 2024

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through OCA/oca-ci#10 and I think I could do that, if nobody's working on it currently.

@PabloEForgeFlow cool, that is most welcome. Just checking if @rousseldenis was not planning to do the same.

@PabloEForgeFlow You can do it as the solution proposed is simpler than mine.

Ping me if you want review.

@PabloEForgeFlow
Copy link

Great I'll be working on it then, thanks @sbidoul @rousseldenis.

@PabloEForgeFlow
Copy link

Hey @sbidoul @rousseldenis , I've implemented a first version of OCA/oca-ci#10 in OCA/oca-ci#77, let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants