[ADD] oca_checklog_odoo: configurable failure on WARNING log messages #77
Conversation
|
I've had a brief look, and the PR looks great. Regarding the python 3.5 test, well... I wonder if OCA should not simply stop supporting Odoo 11. |
bin/oca_checklog_odoo
Outdated
| if [ -n "${OCA_ENABLE_CHECKLOG_ODOO}" ]; then | ||
| checklog-odoo | ||
| else | ||
| checklog-odoo -i ".*" |
There was a problem hiding this comment.
I know I proposed this approach, but I wonder if we could use a simple unix command instead such as cat?
There was a problem hiding this comment.
I mean, specifically for the case when we don't want to check logs
There was a problem hiding this comment.
Yeah, that would probably make more sense. Changed it just now
…st_database and oca_run_tests
PabloEForgeFlow
force-pushed
the
add-checklog-odoo
branch
from
50fa884
to
8dbb91e
Compare
Apparently it's been almost a decade since 3.5 was released, so yeah it might be time to let it go |
This PR implements #10 by doing the following:
bin/oca_checklog_odoo, which fails on stdinWARNINGlog messages whenOCA_ENABLE_CHECKLOG_ODOOis setoca_init_test_databaseandoca_run_teststooca_checklog_odootests/test_checklog.py