[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

AungKoKoLin1997 · 2024-06-06T10:19:32Z

Before this commit, the QC inspection was only triggered when the picking was already done. So, users could check the QC inspection only after the done state.

With this commit, the QC inspection can be triggered with three options ("Before", "Plan Ahead", and "After"). This allows the QC inspection to be triggered both when the picking is in progress and when it is done, enabling users to check the quality at any stage.

This PR does following:

Add date_done field in qc.inspection
- Update date_done when status is success or fail
- Clear date_done when status is reset to draft
Update form and list views to show date, and date_done
Add date and date_done fields in the search filter
Add the timing field in the QC trigger line to enable
- When timing is 'After', an inspection is generated when a picking with the trigger is done.
- When timing is 'Before', an inspection is generated for each related
  move when a picking with the trigger is confirmed.
- When timing is 'Plan Ahead', a 'Plan' inspection is generated for
  each related move when a picking with the trigger is confirmed. A
  plan inspection is just a plan, and cannot be updated except for the
  date. A plan inspection gets converted into an executable inspection
  once the picking is done.

@qrtl QT4613

yostashiro · 2024-06-06T13:29:08Z

quality_control_oca/models/qc_inspection.py

        required=True,
        readonly=True,
        copy=False,
        default=fields.Datetime.now,
        states={"draft": [("readonly", False)]},
    )
+    date_done = fields.Datetime(readonly=True)


Just to make the name presentation somewhat consistent among date fields.

Suggested change

date_done = fields.Datetime(readonly=True)

date_done = fields.Datetime(readonly=True, "Completion Date")

create_date = fields.Datetime("Create Date")

yostashiro · 2024-06-06T13:49:11Z

quality_control_oca/views/qc_inspection_view.xml

+                <field name="create_date" optional="show" />
+                <field name="date" optional="show" />
+                <field name="date_done" optional="show" />


I'd prefer to have these fields after product_id, to be slightly less invasive.

yostashiro · 2024-06-06T13:50:51Z

quality_control_oca/views/qc_inspection_view.xml

@@ -171,6 +176,9 @@
                    domain="[('success', '=', False)]"
                />
                <newline />
+                <separator />
+                <filter name="plan_date" string="Plan Date" date="date" />
+                <filter name="date_done" string="Date Done" date="date_done" />


Suggested change

<filter name="date_done" string="Date Done" date="date_done" />

<filter name="date_done" string="Completion Date" date="date_done" />

yostashiro · 2024-06-06T13:51:17Z

quality_control_oca/views/qc_inspection_view.xml

+                        context="{'group_by': 'date'}"
+                    />
+                    <filter
+                        string="Date Done"


Suggested change

string="Date Done"

string="Completion Date"

quality_control_oca/models/qc_inspection.py

+    def write(self, vals):
+        if "state" in vals:
+            if vals["state"] in ["success", "failed"]:
+                vals["date_done"] = datetime.now()
+            elif vals["state"] == "draft":
+                vals["date_done"] = False
+        return super().write(vals)


yostashiro

Code review. LGTM.

Should we add a post init hook script to populate the new date_done field based on write_date or something?

yostashiro

I think we can squash commits into one at this point, combining descriptions as well.

yostashiro · 2024-06-19T08:35:13Z

quality_control_oca/i18n/ja.po

Please don't include the .po file in the PR.

yostashiro · 2024-06-19T09:46:16Z

quality_control_stock_oca/tests/test_quality_control_stock.py

+        )
+
+    @mute_logger("odoo.models.unlink")
+    def test_inspection_create_for_template_with_before_timing(self):


Let's remove the new test cases added here and onwards as they are redundant. Capturing triggers is already covered by existing tests.

yostashiro · 2024-06-19T09:48:55Z

quality_control_stock_oca/readme/CONFIGURE.rst

Please make this section comprehensive and concise, instead of being so detailed on one of the configuration point.

yostashiro · 2024-06-19T09:53:30Z

quality_control_stock_oca/models/stock_move.py

+        # To avoid CacheMiss error from tests of other modules
+        if "picking_type_id" not in self._cache:
+            return


Not sure this is the right approach. Would be nice if someone could advise.

yostashiro · 2024-06-28T08:38:58Z

quality_control_stock_oca/readme/CONFIGURE.rst

@@ -0,0 +1,12 @@
+Configure a QC trigger in the product, product template, or product category to create inspections efficiently:


Suggested change

Configure a QC trigger in the product, product template, or product category to create inspections efficiently:

Configure a QC trigger in the product, product template, or product category to define the conditions for creating inspections:

yostashiro · 2024-06-28T08:40:34Z

quality_control_stock_oca/readme/CONFIGURE.rst

+
+This streamlined configuration ensures that QC inspections are created and managed effectively based on your specified triggers and conditions.


Let's remove this part as I believe that the intention is obvious.

Suggested change

This streamlined configuration ensures that QC inspections are created and managed effectively based on your specified triggers and conditions.

yostashiro

Code review. 👍

kanda999

Functional review.

OCA-git-bot · 2024-07-02T08:53:51Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-07-02T08:53:52Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AungKoKoLin1997 · 2024-07-30T09:22:55Z

@OCA-manufacture-maintainer
Could you please review this improvement PR?

This commit adds date_done field, update views and filters and the timing field in the QC trigger line to enable following scenarios: - When timing is 'Before', an inspection is generated for each related move when a picking with the trigger is confirmed. - When timing is 'Plan Ahead', a 'Plan' inspection is generated for each related move when a picking with the trigger is confirmed. A plan inspection is just a plan, and cannot be updated except for the date. A plan inspection gets converted into an executable inspection once the picking is done.

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from e1f110e to e7ff281 Compare June 6, 2024 10:22

yostashiro reviewed Jun 6, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 4 times, most recently from b290d21 to 7eecf03 Compare June 7, 2024 09:08

yostashiro approved these changes Jun 7, 2024

View reviewed changes

AungKoKoLin1997 marked this pull request as draft June 18, 2024 04:32

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from d235144 to cc49325 Compare June 18, 2024 14:31

AungKoKoLin1997 marked this pull request as ready for review June 18, 2024 14:31

AungKoKoLin1997 changed the title ~~[16.0][IMP] quality_control_oca: add date_done field, update views, and add filters~~ [16.0][IMP] quality_control_oca, quality_control_stock_oca Jun 18, 2024

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from cc49325 to 374baf4 Compare June 18, 2024 14:44

AungKoKoLin1997 requested a review from yostashiro June 18, 2024 15:01

yostashiro suggested changes Jun 19, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from d909498 to 62bbcbe Compare June 19, 2024 10:44

AungKoKoLin1997 requested a review from yostashiro June 21, 2024 08:58

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from 9a5f302 to b5ad9ad Compare June 25, 2024 05:30

yostashiro mentioned this pull request Jun 26, 2024

Quality check based on workcenter at cycle count #1292

Open

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from b5ad9ad to 471e306 Compare June 26, 2024 06:38

yostashiro reviewed Jun 28, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from 471e306 to 6078aa6 Compare June 28, 2024 09:07

yostashiro approved these changes Jun 28, 2024

View reviewed changes

kanda999 approved these changes Jul 2, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 2, 2024

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from 6078aa6 to 3e18fab Compare August 29, 2024 08:08

AungKoKoLin1997 and others added 2 commits September 2, 2024 11:33

[IMP] quality_control_mrp_oca: add timings

8d6f95e

AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch from 3e18fab to 8d6f95e Compare September 2, 2024 04:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

AungKoKoLin1997 commented Jun 6, 2024 •

edited

Loading

yostashiro Jun 6, 2024

yostashiro Jun 6, 2024

yostashiro Jun 6, 2024

yostashiro Jun 6, 2024

This comment was marked as outdated.

yostashiro left a comment

yostashiro left a comment

yostashiro Jun 19, 2024

yostashiro Jun 19, 2024

yostashiro Jun 19, 2024

yostashiro Jun 19, 2024

yostashiro Jun 28, 2024

yostashiro Jun 28, 2024

yostashiro left a comment

kanda999 left a comment

OCA-git-bot commented Jul 2, 2024

OCA-git-bot commented Jul 2, 2024

AungKoKoLin1997 commented Jul 30, 2024

	date_done = fields.Datetime(readonly=True)
	date_done = fields.Datetime(readonly=True, "Completion Date")
	create_date = fields.Datetime("Create Date")

	<filter name="date_done" string="Date Done" date="date_done" />
	<filter name="date_done" string="Completion Date" date="date_done" />

		@@ -0,0 +1,12 @@
		Configure a QC trigger in the product, product template, or product category to create inspections efficiently:


		This streamlined configuration ensures that QC inspections are created and managed effectively based on your specified triggers and conditions.

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

Are you sure you want to change the base?

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

Conversation

AungKoKoLin1997 commented Jun 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

kanda999 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 2, 2024

OCA-git-bot commented Jul 2, 2024

AungKoKoLin1997 commented Jul 30, 2024

AungKoKoLin1997 commented Jun 6, 2024 •

edited

Loading