[12.0] [MIG] Product Brand #390

ThomasBinsfeld · 2018-10-02T11:53:15Z

Migration of product_attribute from 11.0 to 12.0.
#389

acsonefho

LGTM (about code)

SimoRubi

code review and tested on runbot

product_brand/models/product_brand.py

product_brand/readme/USAGE.rst

nikul-serpentcs

Small Change

product_brand/__manifest__.py

pedrobaeza · 2018-10-11T18:04:59Z

Please check Travis and runbot status

pedrobaeza · 2018-10-11T18:06:04Z

This also misses commits from #365

pedrobaeza · 2018-10-11T20:26:49Z

@ThomasBinsfeld can you please review #364 and incorporate it here if everything is correct?

pedrobaeza · 2018-10-12T12:04:23Z

#364 has been merged

… Thanks to NetAndCo who starts the module

* add smart button, move menu to a more visible position. * show brand in product.template kanban and tree views. * show brand in product variant kanban and tree views. * add product_brand kanban view. * update module's README and manifest file. * Search and group by brand for both product.product and product.template. * Convert model to new APIs. * Refactor products_count computation using product_ids one2many field. * Add public read access to product.brand (fixes 403 error on webshop for public user). * Make brand name required.

Migration to 10.0

Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.

Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.

Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/

… with other odoo apps. (OCA#364) * Make the logo always the same width (64px). * Remove the description (200 first caracters). Not relevant for a configuration model. * Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.

ThomasBinsfeld · 2018-10-25T08:49:53Z

@pedrobaeza All 11.0 commits are here now

pedrobaeza · 2018-10-27T16:39:14Z

2 little pylint things:

product_brand/models/product_brand.py:31: [C8108(method-compute), ProductBrand] Name of compute method should start with "_compute_"
product_brand/reports/sale_report.py:15: [W0102(dangerous-default-value), SaleReport._query] Dangerous default value {} as argument

pedrobaeza · 2018-10-27T16:40:06Z

@SimoRubi @nikul-serpentcs can you review again?

bealdav · 2018-10-28T16:15:59Z

product_brand/reports/account_invoice_report.py

+        select_str += """
+            , sub.product_brand_id as product_brand_id
+            """
+        return select_str


can be summarized by

return super()._select() + ", sub.product_brand_id as product_brand_id"

Just typo, not blocking

The same below

@bealdav Thanks for your review. I don't think we should refactor code in migration PR if it's not required. Feel free to submit a refactoring in a PR after the migration merge.

OK. No problem

SimoRubi · 2018-10-29T08:11:13Z

@ThomasBinsfeld please check runbot and Travis, everything is red

product_brand/__manifest__.py

angelmoya

👍

nikul-serpentcs

Minor Change

nikul-serpentcs · 2018-12-13T04:52:52Z

product_brand/tests/test_product_brand.py

+    def setUp(self):
+        super().setUp()
+        self.product = self.env.ref('product.product_product_4')
+        self.supplier = self.ref('base.res_partner_2')


@ThomasBinsfeld Here self.env.ref not self.ref

@nikul-serpentcs self.ref is a good way to get the id of the record and self.env.ref a good way to get the record itself. I won't change it since we only need the ID in this unit test. Please feel free to submit a refactoring PR after the migration merge.

@ThomasBinsfeld In case, In future use supplier record then change the self.env.ref.
meanwhile, We change this(self.env.ref) and using self.supplier.id.

It's not a blocking issue but It's Good for us.

rather than, Code review LGTM.

@ThomasBinsfeld If you're review is non-blocking, you can update your review and add an approval. Thanks for the review.

nikul-serpentcs

Code Revie LGTM 👍

youring · 2018-12-19T01:03:41Z

Can pick #114, or add as an option?

ThomasBinsfeld · 2018-12-19T08:23:38Z

@youring I don't plan to forward port improvements from previous versions in this migration. But feel free to open a pull request targeting my branch and I will review/merge it.

ghost · 2019-01-07T12:19:40Z

Could this PR merged?

pedrobaeza · 2019-01-07T12:20:35Z

Please squash migration commits together.

ThomasBinsfeld · 2019-01-07T12:22:14Z

@pedrobaeza Done

ThomasBinsfeld force-pushed the 12-mig_product_brand_tbi branch 2 times, most recently from 203a5e7 to 6402016 Compare October 2, 2018 11:59

acsonefho approved these changes Oct 2, 2018

View reviewed changes

mpanarin approved these changes Oct 2, 2018

View reviewed changes

SimoRubi suggested changes Oct 2, 2018

View reviewed changes

product_brand/models/product_brand.py Outdated Show resolved Hide resolved

product_brand/readme/USAGE.rst Show resolved Hide resolved

nikul-serpentcs reviewed Oct 2, 2018

View reviewed changes

product_brand/__manifest__.py Show resolved Hide resolved

pedrobaeza added this to the 12.0 milestone Oct 11, 2018

OCA-git-bot mentioned this pull request Oct 11, 2018

Migration to version 12.0 #389

Closed

24 tasks

bguillot and others added 18 commits October 25, 2018 09:31

[INIT] init module product_brand extract from trunk-addons-community.…

92bb6f6

… Thanks to NetAndCo who starts the module

migration of product_brand for version 7.0

95c919b

Launchpad automatic translations update.

802cef7

Set all addons to uninstallable and move them into __unported__ folder

1dbb0d9

portation of product_brand to 8.0

6be3175

[MIG] product_brand :Updated module as per v9

4306460

[MIG][10.0] product_brand (OCA#191)

a0a8f1b

Migration to 10.0

OCA Transbot updated translations from Transifex

8ec2944

Update product_brand.py

e2d4b94

OCA Transbot updated translations from Transifex

4ac271c

[IMP] product_brand: update form view for 10.0

50dcec8

Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.

[MIG] : Migration to 11.0 + Test

519c904

[FIX] product_brand: Don't format the ID (OCA#355)

31a4395

Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.

remove obsolete .pot files [ci skip]

f6d6ac2

[UPD] Update product_brand.pot

b726af4

[IMP] product_branch: Order brands by name

811a613

product_brand: complete fr translation

0322c33

Axel-G and others added 6 commits October 25, 2018 09:31

Translated using Weblate (German)

3444675

Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/

[MIG] Merge product_brand_sale_report into product_brand

d5cf08b

[MIG] Merge product_brand_invoice_report into product_brand

e9ee58a

[UPD] Update product_brand.pot

c2b9f5e

[UPD] README.rst

5cf17aa

ThomasBinsfeld force-pushed the 12-mig_product_brand_tbi branch from 6402016 to 5b2e212 Compare October 25, 2018 08:49

bealdav reviewed Oct 28, 2018

View reviewed changes

lmignon reviewed Oct 29, 2018

View reviewed changes

product_brand/__manifest__.py Show resolved Hide resolved

ThomasBinsfeld force-pushed the 12-mig_product_brand_tbi branch 2 times, most recently from 1a51c33 to a97bd05 Compare October 29, 2018 09:36

angelmoya approved these changes Dec 12, 2018

View reviewed changes

nikul-serpentcs suggested changes Dec 13, 2018

View reviewed changes

nikul-serpentcs approved these changes Dec 14, 2018

View reviewed changes

[MIG] product_brand to 12.0

bb05cb7

ThomasBinsfeld force-pushed the 12-mig_product_brand_tbi branch from a97bd05 to bb05cb7 Compare January 7, 2019 12:22

pedrobaeza merged commit 8c31793 into OCA:12.0 Jan 7, 2019

ThomasBinsfeld deleted the 12-mig_product_brand_tbi branch January 7, 2019 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0] [MIG] Product Brand #390

[12.0] [MIG] Product Brand #390

ThomasBinsfeld commented Oct 2, 2018

acsonefho left a comment

SimoRubi left a comment

nikul-serpentcs left a comment

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 12, 2018

ThomasBinsfeld commented Oct 25, 2018

pedrobaeza commented Oct 27, 2018

pedrobaeza commented Oct 27, 2018

bealdav Oct 28, 2018 •

edited

Loading

ThomasBinsfeld Dec 13, 2018

bealdav Dec 14, 2018

SimoRubi commented Oct 29, 2018

angelmoya left a comment

nikul-serpentcs left a comment

nikul-serpentcs Dec 13, 2018

ThomasBinsfeld Dec 13, 2018

nikul-serpentcs Dec 13, 2018 •

edited

Loading

ThomasBinsfeld Dec 13, 2018

nikul-serpentcs left a comment

youring commented Dec 19, 2018

ThomasBinsfeld commented Dec 19, 2018 •

edited

Loading

ghost commented Jan 7, 2019

pedrobaeza commented Jan 7, 2019

ThomasBinsfeld commented Jan 7, 2019

[12.0] [MIG] Product Brand #390

[12.0] [MIG] Product Brand #390

Conversation

ThomasBinsfeld commented Oct 2, 2018

acsonefho left a comment

Choose a reason for hiding this comment

SimoRubi left a comment

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

pedrobaeza commented Oct 12, 2018

ThomasBinsfeld commented Oct 25, 2018

pedrobaeza commented Oct 27, 2018

pedrobaeza commented Oct 27, 2018

bealdav Oct 28, 2018 • edited Loading

Choose a reason for hiding this comment

ThomasBinsfeld Dec 13, 2018

Choose a reason for hiding this comment

bealdav Dec 14, 2018

Choose a reason for hiding this comment

SimoRubi commented Oct 29, 2018

angelmoya left a comment

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

nikul-serpentcs Dec 13, 2018

Choose a reason for hiding this comment

ThomasBinsfeld Dec 13, 2018

Choose a reason for hiding this comment

nikul-serpentcs Dec 13, 2018 • edited Loading

Choose a reason for hiding this comment

ThomasBinsfeld Dec 13, 2018

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

youring commented Dec 19, 2018

ThomasBinsfeld commented Dec 19, 2018 • edited Loading

ghost commented Jan 7, 2019

pedrobaeza commented Jan 7, 2019

ThomasBinsfeld commented Jan 7, 2019

bealdav Oct 28, 2018 •

edited

Loading

nikul-serpentcs Dec 13, 2018 •

edited

Loading

ThomasBinsfeld commented Dec 19, 2018 •

edited

Loading