Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] product_firmware_version #427

Merged
merged 4 commits into from
Feb 28, 2020
Merged

[12.0] [MIG] product_firmware_version #427

merged 4 commits into from
Feb 28, 2020

Conversation

Nikul-Chaudhary
Copy link
Member

Product firmware version

This module allows you to store the latest/official/tested firmware version on an electronic product.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Jan 29, 2019
Closed
24 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 29, 2019
@Nikul-Chaudhary
Copy link
Member Author

@OCA/product-maintainers could you please review code?

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @bodedra Could you please review it?

tbaden
tbaden suggested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
code lgtm
just a minor detail

product_firmware_version/README.rst
@@ -0,0 +1,61 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the new README by fragment system and generate the README.rst with the maintainer-tools

@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 12-mig-product_firmware_version branch from c052feb to 730cc7a Compare June 20, 2019 11:06
@Nikul-Chaudhary
Copy link
Member Author

@tbaden @bodedra Code you please review again?

bodedra
bodedra approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Runbot. LGTM 👍

@Nikul-Chaudhary Thanks for migration.

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @rafaelbn Can you please review and move forward.

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @rafaelbn @max3903 if you don't mind, can you please review it?

emagdalenaC2i
emagdalenaC2i approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-427-by-simahawk-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 28, 2020
@OCA-git-bot
Merge PR #427 into 12.0
25d880d 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-427-by-simahawk-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 28, 2020
@OCA-git-bot
Merge PR #427 into 12.0
cc78736 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-427-by-simahawk-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 28, 2020
@OCA-git-bot
Merge PR #427 into 12.0
e8c9256 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-427-by-simahawk-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4dae981. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit cdebf69 into OCA:12.0 Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden requested changes

@bodedra bodedra bodedra approved these changes

@emagdalenaC2i emagdalenaC2i emagdalenaC2i approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Nikul-Chaudhary @simahawk @OCA-git-bot @tbaden @bodedra @emagdalenaC2i @pedrobaeza @oca-transbot @oca-travis