-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][12.0] product_weight #449
Conversation
4f5d705
to
3b77a1f
Compare
3b77a1f
to
c07d769
Compare
c07d769
to
0c89a81
Compare
Hey @tbaden, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
added missing commit history |
@pedrobaeza runbot is getting killed after 40 minutes without valid logs to check. |
There's a problem right now with the sizing of the servers. Let's see if @gurneyalex can fix it soon. Meanwhile, force a rebuild to see if you can get it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the PR.
There is a bug in case of multi level bom if the bom lines have a quantity different than 1
More explanation and the fix here : tbaden#1
@florian-dacosta thanks for the information, I'll attend these changes at the end of this week. |
Any news on this? |
@pedrobaeza is that the right way to merge the fix into the PR? |
Yes, but I see one line that can be removed commented on the original PR. |
ce3b325
to
2465903
Compare
fixed it. |
… and possibility to calculate weight for multi products
Currently translated at 100.0% (18 of 18 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_weight Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_weight/es/
2465903
to
db61188
Compare
db61188
to
d1e785b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended commit history and changes seems OK, so counting with implicit @florian-dacosta approval, I'm merging.
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 6c54a01. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Migration of product_weight to v12