Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] [MIG] stock_production_lot_firmware_version #513

Merged
merged 7 commits into from
Dec 23, 2019
Merged

[13.0] [MIG] stock_production_lot_firmware_version #513

merged 7 commits into from
Dec 23, 2019

Conversation

Nikul-Chaudhary
Copy link
Member

Stock product lot firmware version

This module allows you to store the current firmware version on an serialized electronic item.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Oct 1, 2019
Closed
24 tasks
@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 13-mig-stock_production_lot_firmware_version branch from 69b0a12 to 7eb586a Compare October 21, 2019 16:02
@Nikul-Chaudhary Nikul-Chaudhary force-pushed the 13-mig-stock_production_lot_firmware_version branch from a393dc8 to a716acb Compare October 22, 2019 02:29
@Nikul-Chaudhary
Copy link
Member Author

@sudhir-erpharbor @aheficent @bodedra can you please review it?

bodedra
bodedra suggested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikul-Chaudhary Thanks for module migration. Would you please remove your cosmetic changes.

I just do comment just before your code/changes.

stock_production_lot_firmware_version/__manifest__.py Outdated
],
"data": [
"views/stock_view.xml",
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid cosmetic changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodedra FYI, Here Pre-commit suggest this kind of changes. That's why I changed code as per pre-commit

If not change then Travis is Failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Good to know. Thank you.

stock_production_lot_firmware_version/models/stock.py Outdated
@@ -5,8 +5,6 @@


class StockProductionLot(models.Model):
_inherit = 'stock.production.lot'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

stock_production_lot_firmware_version/models/stock.py Outdated

firmware_version = fields.Char(
string='Firmware Version'
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

bodedra
bodedra approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sudhir-erpharbor
sudhir-erpharbor approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@sudhir-erpharbor sudhir-erpharbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally and Code review LGTM.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza @max3903 ready to merge

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-513-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 23, 2019
@OCA-git-bot
Merge PR #513 into 13.0
0c5e26f 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit a716acb into OCA:13.0 Dec 23, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d123709. Thanks a lot for contributing to OCA. ❤️

@Nikul-Chaudhary Nikul-Chaudhary deleted the 13-mig-stock_production_lot_firmware_version branch December 25, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhir-erpharbor sudhir-erpharbor sudhir-erpharbor approved these changes

@bodedra bodedra bodedra approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nikul-Chaudhary @OCA-git-bot @pedrobaeza @sudhir-erpharbor @bodedra @oca-transbot @oca-travis