Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][13.0] Migrate product_manufacturer #538

Merged
merged 16 commits into from
Dec 27, 2019

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 18, 2019

No description provided.

@oca-clabot
Copy link

Hey @guewen, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 18, 2019
24 tasks
<page name="general_information" position="inside">
<group name="manufacturer" string="Manufacturer">
<group>
<field name="manufacturer" context="{'default_supplier':True, 'default_customer':False}"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this context is not working, I can select customers and suppliers now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, odoo behaves differently in this regard now: it always shows everything (suppliers and customers), but orders them by putting suppliers (or customers) first. The new context key to use is {'res_partner_search_mode': 'supplier'}. I fixed this.

Thanks for the review!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works now.

Copy link

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-538-by-JordiBForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 27, 2019
Signed-off-by JordiBForgeFlow
@OCA-git-bot OCA-git-bot merged commit 95b317e into OCA:13.0 Dec 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a04ce89. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.