-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][13.0] Migrate product_manufacturer #538
Conversation
* New Field Added to store the URL of the product on the manufacturer page. * Added field manufacturer product URL to the product view. * README updated.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Add # -*- encoding: utf-8 -*-
Hey @guewen, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
<page name="general_information" position="inside"> | ||
<group name="manufacturer" string="Manufacturer"> | ||
<group> | ||
<field name="manufacturer" context="{'default_supplier':True, 'default_customer':False}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this context is not working, I can select customers and suppliers now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, odoo behaves differently in this regard now: it always shows everything (suppliers and customers), but orders them by putting suppliers (or customers) first. The new context key to use is {'res_partner_search_mode': 'supplier'}
. I fixed this.
Thanks for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Works now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review 👍
This PR has the |
/ocabot merge |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at a04ce89. Thanks a lot for contributing to OCA. ❤️ |
No description provided.