Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] product_template_tags #542

Merged
merged 11 commits into from
Feb 13, 2020

Conversation

ps-tubtim
Copy link
Member

No description provided.

patrickrwilson and others added 10 commits December 20, 2019 17:20
[UPD] Suggested Changes

Updated code based on reviews

[UPD] Add readme folder

Added readme folder and made it so tags can be colored.

[UPD] Aesthetic Changes

Aesthetic changes requested from reviewer.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_template_tags/
@OCA-git-bot
Copy link
Contributor

Hi @patrickrwilson,
some modules you are maintaining are being modified, check this out!

@ps-tubtim ps-tubtim force-pushed the 13.0-mig-product_template_tags branch from e0de626 to b38d146 Compare December 23, 2019 03:08
@ps-tubtim ps-tubtim force-pushed the 13.0-mig-product_template_tags branch 2 times, most recently from b9282a0 to c044f22 Compare January 2, 2020 10:42
Copy link

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working but I think it should have a menu option to manage the tags.

@i-vyshnevska
Copy link
Member

@lfreeke there is menu called "Product Tags"

<field name="model">product.template</field>
<field name="inherit_id" ref="product.product_template_form_view"/>
<field name="arch" type="xml">
<xpath expr="//page[@name='general_information']" position="inside">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #568

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Edited.

@lfreeke
Copy link

lfreeke commented Feb 10, 2020

@i-vyshnevska You are totally correct! I would have expected it somewhere else.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ps-tubtim ps-tubtim force-pushed the 13.0-mig-product_template_tags branch from 63ffaa1 to c83d30c Compare February 11, 2020 02:29
Copy link
Contributor

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-542-by-simahawk-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 13, 2020
Signed-off-by simahawk
@OCA-git-bot OCA-git-bot merged commit c83d30c into OCA:13.0 Feb 13, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 13a778e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.