-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] product_template_tags #542
[13.0][MIG] product_template_tags #542
Conversation
[UPD] Suggested Changes Updated code based on reviews [UPD] Add readme folder Added readme folder and made it so tags can be colored. [UPD] Aesthetic Changes Aesthetic changes requested from reviewer.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_template_tags Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_template_tags/
Hi @patrickrwilson, |
e0de626
to
b38d146
Compare
b9282a0
to
c044f22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working but I think it should have a menu option to manage the tags.
@lfreeke there is menu called "Product Tags" |
<field name="model">product.template</field> | ||
<field name="inherit_id" ref="product.product_template_form_view"/> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//page[@name='general_information']" position="inside"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Edited.
@i-vyshnevska You are totally correct! I would have expected it somewhere else. |
This PR has the |
63ffaa1
to
c83d30c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 13a778e. Thanks a lot for contributing to OCA. ❤️ |
No description provided.