Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile #102

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Update dockerfile #102

merged 7 commits into from
Feb 19, 2024

Conversation

joschrew
Copy link
Collaborator

This PR is part of series to offer single ocrd modules as Docker Containers (ocrd slim containers) to be used with ocr-d network.

Previously it was based on nvcr.io/nividia. I don't know why I changed it to be based on ocr-d core

@joschrew joschrew marked this pull request as draft January 31, 2024 14:12
@bertsky
Copy link
Contributor

bertsky commented Feb 12, 2024

Previously it was based on nvcr.io/nividia. I don't know why I changed it to be based on ocr-d core

I think that's ok, but we should use ocrd/core-cuda instead of plain ocrd/core.

Also, I don't understand why the CI does not trigger anymore. It's obviously broken now, but no logs can be viewed. And on CircleCI it even says there's no active configuration (for me anyway). @kba would you be able to help?

@joschrew
Copy link
Collaborator Author

I have now switched to core-cuda as base image. This image is really huge with 11 GB.

@kba
Copy link
Member

kba commented Feb 19, 2024

Also, I don't understand why the CI does not trigger anymore. It's obviously broken now, but no logs can be viewed. And on CircleCI it even says there's no active configuration (for me anyway). @kba would you be able to help?

Why the builds stopped working altogether, I don't know. I've reset the connection GH/CircleCI. This PR was not tested because building forked PR was turned off.

Tests fail because of an issue with resmgr but I won't waste time debugging this essentially moribund project, tests pass locally.

@kba kba marked this pull request as ready for review February 19, 2024 17:19
@kba kba merged commit 66aa8bc into OCR-D:master Feb 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants