Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tolerances updated #45

Merged
merged 21 commits into from
Dec 18, 2023
Merged

Test tolerances updated #45

merged 21 commits into from
Dec 18, 2023

Conversation

JordiBolibar
Copy link
Member

No description provided.

The test suite is starting to become a little bit more complete.
Now we can run simulations with MB, run by Muninn. New tests have been added covering those usescases. This means that Huginn should be ready to run simulations for most cases. Now it needs to be extensively tested for different regions and finish polishing the remaining issues.
I fixed an issue with the MB mask, where ice was weirdly flowing outside the catchment. I have also added multiprocessing, which still hadn't been implemented from the old architecture.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@7e3bfd4). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   92.28%           
=======================================
  Files           ?       10           
  Lines           ?      402           
  Branches        ?        0           
=======================================
  Hits            ?      371           
  Misses          ?       31           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiBolibar JordiBolibar merged commit 1444828 into ODINN-SciML:main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants