Handle untyped collections in context's getedmtype method #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
reviewed
Sep 4, 2018
| @@ -161,6 +163,22 @@ internal IEdmTypeReference GetEdmType(object instance, Type type) | |||
| typeof(IEdmObject).Name); | |||
| } | |||
| } | |||
| else if (typeof(IEnumerable).IsAssignableFrom(type) && | |||
| typeof(IEdmObject).IsAssignableFrom(type.GetGenericArguments().FirstOrDefault())) | |||
There was a problem hiding this comment.
Web API recommends to use "EdmEnittyObjectCollection, EdmComplexObjectCollection, EdmEnumObjectCollection" for the collection. #WontFix
There was a problem hiding this comment.
my approach is consistent with the approaches used in this class and others in webapi.
In reply to: 215081845 [](ancestors = 215081845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*This pull request fixes issue #1597
Description
I could find no alternative to resolve a query using the ODataResourceSetSerializer than including the block of code that I have added to the ODataSerializerContext.GetEdmType method. Given that the method is called by the WriteObject method in the ResourceSet Serializer, please explain how to make that call succeed when a collection of EdmEntityObject or EdmComplexObject is provided given the remainder of the logic in the method. Note that I am producing the IEdmModel by directly consuming the csdl generated by a tool.